Done. Brad
-----Original Message----- From: Nilay Vaish [mailto:ni...@cs.wisc.edu] Sent: Tuesday, December 07, 2010 4:43 PM To: Beckmann, Brad Cc: Default Subject: Re: Review Request: NDEBUG for Ruby Assert statement Brad, Since Steve and you have reviewed the patch, I guess we can commit it. I have one more patch in the queue. Nilay On Fri, 3 Dec 2010, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/337/#review509 > ----------------------------------------------------------- > > Ship it! > > > Looks good to me. > > - Brad > > > On 2010-12-02 20:35:31, Nilay Vaish wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviews.m5sim.org/r/337/ >> ----------------------------------------------------------- >> >> (Updated 2010-12-02 20:35:31) >> >> >> Review request for Default. >> >> >> Summary >> ------- >> >> This diff is for changing the way ASSERT is handled in Ruby. m5.fast >> compiles out the assert statements by using the macro NDEBUG. Ruby uses the >> macro RUBY_NO_ASSERT to do so. This macro has been removed and NDEBUG has >> been put in its place. >> >> >> Diffs >> ----- >> >> src/mem/ruby/common/Debug.hh 42da07116e12 >> src/mem/slicc/ast/FuncCallExprAST.py 42da07116e12 >> >> Diff: http://reviews.m5sim.org/r/337/diff >> >> >> Testing >> ------- >> >> I have compiled the source code with this change. The object files created >> for debug version have the assert statements while those for the fast >> version don't. >> >> >> Thanks, >> >> Nilay >> >> > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
