----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/336/#review516 -----------------------------------------------------------
src/cpu/testers/rubytest/Check.cc <http://reviews.m5sim.org/r/336/#comment759> You don't need to do %lld with cprintf/warn/dprintf. %d works just fine. src/cpu/testers/rubytest/Check.cc <http://reviews.m5sim.org/r/336/#comment758> If you're going to panic, why bother with the warn? I know that you're mirroring what is already there, but it doesn't really make sense to me. It would probably be nice to make the error messages a little more verbose, but then again, perhaps that should just be a different changeset. - Nathan On 2010-12-08 16:18:20, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/336/ > ----------------------------------------------------------- > > (Updated 2010-12-08 16:18:20) > > > Review request for Default. > > > Summary > ------- > > This patch removes the WARN_* and ERROR_* from src/mem/ruby/common/Debug.hh > file. These statements have been replaced with warn(), panic() and fatal() > defined in src/base/misc.hh > > > Diffs > ----- > > src/cpu/testers/rubytest/Check.cc f6cbeb8712d3 > src/cpu/testers/rubytest/CheckTable.cc f6cbeb8712d3 > src/cpu/testers/rubytest/RubyTester.cc f6cbeb8712d3 > src/mem/protocol/RubySlicc_Util.sm f6cbeb8712d3 > src/mem/ruby/buffers/MessageBuffer.cc f6cbeb8712d3 > src/mem/ruby/common/Debug.hh f6cbeb8712d3 > src/mem/ruby/common/NetDest.cc f6cbeb8712d3 > src/mem/ruby/common/Set.cc f6cbeb8712d3 > src/mem/ruby/network/Network.cc f6cbeb8712d3 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc f6cbeb8712d3 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc > f6cbeb8712d3 > src/mem/ruby/network/garnet/fixed-pipeline/RoutingUnit_d.cc f6cbeb8712d3 > src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.cc f6cbeb8712d3 > src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.cc f6cbeb8712d3 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc f6cbeb8712d3 > src/mem/ruby/slicc_interface/RubySlicc_ComponentMapping.hh f6cbeb8712d3 > src/mem/ruby/slicc_interface/RubySlicc_Util.hh f6cbeb8712d3 > src/mem/ruby/storebuffer/storebuffer.cc f6cbeb8712d3 > src/mem/ruby/system/CacheMemory.cc f6cbeb8712d3 > src/mem/ruby/system/PerfectCacheMemory.hh f6cbeb8712d3 > src/mem/ruby/system/Sequencer.cc f6cbeb8712d3 > src/mem/ruby/tester/DeterministicDriver.cc f6cbeb8712d3 > src/mem/ruby/tester/RaceyPseudoThread.cc f6cbeb8712d3 > src/mem/ruby/tester/test_framework.cc f6cbeb8712d3 > src/mem/slicc/symbols/StateMachine.py f6cbeb8712d3 > src/mem/slicc/symbols/Type.py f6cbeb8712d3 > > Diff: http://reviews.m5sim.org/r/336/diff > > > Testing > ------- > > > Thanks, > > Nilay > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
