----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/336/ -----------------------------------------------------------
(Updated 2010-12-21 04:31:14.033111) Review request for Default. Changes ------- Removed calls to warn() where followed by fatal()/panic(). Replaced ASSERT(0) calls with panic(). Removed return statements where possible. I have retained calls to fatal() which I think should be fatal() and not panic(). Summary ------- This patch removes the WARN_* and ERROR_* from src/mem/ruby/common/Debug.hh file. These statements have been replaced with warn(), panic() and fatal() defined in src/base/misc.hh Diffs (updated) ----- src/cpu/testers/rubytest/Check.cc 998b217dcae7 src/cpu/testers/rubytest/CheckTable.cc 998b217dcae7 src/cpu/testers/rubytest/RubyTester.cc 998b217dcae7 src/mem/protocol/RubySlicc_Util.sm 998b217dcae7 src/mem/ruby/buffers/MessageBuffer.cc 998b217dcae7 src/mem/ruby/common/Debug.hh 998b217dcae7 src/mem/ruby/common/NetDest.cc 998b217dcae7 src/mem/ruby/common/Set.cc 998b217dcae7 src/mem/ruby/network/Network.cc 998b217dcae7 src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 998b217dcae7 src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc 998b217dcae7 src/mem/ruby/network/garnet/fixed-pipeline/RoutingUnit_d.cc 998b217dcae7 src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.cc 998b217dcae7 src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.cc 998b217dcae7 src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 998b217dcae7 src/mem/ruby/slicc_interface/RubySlicc_ComponentMapping.hh 998b217dcae7 src/mem/ruby/slicc_interface/RubySlicc_Util.hh 998b217dcae7 src/mem/ruby/storebuffer/storebuffer.cc 998b217dcae7 src/mem/ruby/system/CacheMemory.cc 998b217dcae7 src/mem/ruby/system/PerfectCacheMemory.hh 998b217dcae7 src/mem/ruby/system/Sequencer.cc 998b217dcae7 src/mem/ruby/tester/DeterministicDriver.cc 998b217dcae7 src/mem/ruby/tester/RaceyPseudoThread.cc 998b217dcae7 src/mem/ruby/tester/test_framework.cc 998b217dcae7 src/mem/slicc/symbols/StateMachine.py 998b217dcae7 src/mem/slicc/symbols/Type.py 998b217dcae7 Diff: http://reviews.m5sim.org/r/336/diff Testing ------- Thanks, Nilay
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
