I don't have the commit access. Brad will have to do it for me. Or may be
you can.
--
Nilay
On Tue, 21 Dec 2010, nathan binkert wrote:
Nilay,
Can you push this commit as soon as you have time? This one should
definitely go in before my debug changes. I think this will also allow us
to completely get rid of the Debug class in Ruby.
Nate
On Tue, Dec 21, 2010 at 8:12 AM, Steve Reinhardt <[email protected]> wrote:
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/336/
Ship it!
Looks good to me, thanks for the changes!
- Steve
On December 21st, 2010, 4:31 a.m., Nilay Vaish wrote:
Review request for Default.
By Nilay Vaish.
*Updated 2010-12-21 04:31:14*
Description
This patch removes the WARN_* and ERROR_* from src/mem/ruby/common/Debug.hh
file. These statements have been replaced with warn(), panic() and fatal()
defined in src/base/misc.hh
Diffs
- src/cpu/testers/rubytest/Check.cc (998b217dcae7)
- src/cpu/testers/rubytest/CheckTable.cc (998b217dcae7)
- src/cpu/testers/rubytest/RubyTester.cc (998b217dcae7)
- src/mem/protocol/RubySlicc_Util.sm (998b217dcae7)
- src/mem/ruby/buffers/MessageBuffer.cc (998b217dcae7)
- src/mem/ruby/common/Debug.hh (998b217dcae7)
- src/mem/ruby/common/NetDest.cc (998b217dcae7)
- src/mem/ruby/common/Set.cc (998b217dcae7)
- src/mem/ruby/network/Network.cc (998b217dcae7)
- src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc
(998b217dcae7)
- src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc
(998b217dcae7)
- src/mem/ruby/network/garnet/fixed-pipeline/RoutingUnit_d.cc
(998b217dcae7)
- src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.cc
(998b217dcae7)
- src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.cc
(998b217dcae7)
- src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc
(998b217dcae7)
- src/mem/ruby/slicc_interface/RubySlicc_ComponentMapping.hh
(998b217dcae7)
- src/mem/ruby/slicc_interface/RubySlicc_Util.hh (998b217dcae7)
- src/mem/ruby/storebuffer/storebuffer.cc (998b217dcae7)
- src/mem/ruby/system/CacheMemory.cc (998b217dcae7)
- src/mem/ruby/system/PerfectCacheMemory.hh (998b217dcae7)
- src/mem/ruby/system/Sequencer.cc (998b217dcae7)
- src/mem/ruby/tester/DeterministicDriver.cc (998b217dcae7)
- src/mem/ruby/tester/RaceyPseudoThread.cc (998b217dcae7)
- src/mem/ruby/tester/test_framework.cc (998b217dcae7)
- src/mem/slicc/symbols/StateMachine.py (998b217dcae7)
- src/mem/slicc/symbols/Type.py (998b217dcae7)
View Diff <http://reviews.m5sim.org/r/336/diff/>
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
