----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/380/#review656 -----------------------------------------------------------
If these are adapted from Rick's patches, what was the license on those patches? src/cpu/BaseCPU.py <http://reviews.m5sim.org/r/380/#comment893> Is this supposed to be here? It doesn't seem related to McPAT. What does it do anyway? Also, this should be done by adding a couple of new params with default '=None' values instead of duplicating code (note that this already seems broken wrt ARM and interrupt support when comparing with the preceding version). src/cpu/base.hh <http://reviews.m5sim.org/r/380/#comment894> This needs to be a System-object field, not a global, so it works when doing multi-system simulations. src/cpu/base.hh <http://reviews.m5sim.org/r/380/#comment895> Same here. src/cpu/o3/inst_queue_impl.hh <http://reviews.m5sim.org/r/380/#comment896> I'm curious why this counts as a read and a write... is the write just the update to remove the inst? Shouldn't that be cheaper than actually writing a new instruction into the queue? - Steve On 2011-01-06 15:53:31, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/380/ > ----------------------------------------------------------- > > (Updated 2011-01-06 15:53:31) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > mcpat: Adds McPAT performance counters > > Updated patches from Rick Strong's set that modify performance counters for > McPAT > > > Diffs > ----- > > src/cpu/BaseCPU.py 9f9e10967912 > src/cpu/base.hh 9f9e10967912 > src/cpu/base.cc 9f9e10967912 > src/cpu/o3/commit.hh 9f9e10967912 > src/cpu/o3/commit_impl.hh 9f9e10967912 > src/cpu/o3/cpu.hh 9f9e10967912 > src/cpu/o3/cpu.cc 9f9e10967912 > src/cpu/o3/iew_impl.hh 9f9e10967912 > src/cpu/o3/inst_queue.hh 9f9e10967912 > src/cpu/o3/inst_queue_impl.hh 9f9e10967912 > src/cpu/o3/rename.hh 9f9e10967912 > src/cpu/o3/rename_impl.hh 9f9e10967912 > src/cpu/o3/rob.hh 9f9e10967912 > src/cpu/o3/rob_impl.hh 9f9e10967912 > src/cpu/simple/atomic.cc 9f9e10967912 > src/cpu/simple/base.hh 9f9e10967912 > src/cpu/simple/base.cc 9f9e10967912 > src/cpu/simple/timing.cc 9f9e10967912 > > Diff: http://reviews.m5sim.org/r/380/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
