> On 2011-01-07 08:50:27, Steve Reinhardt wrote: > > If these are adapted from Rick's patches, what was the license on those > > patches?
There was no license with Rick's initial patches. I have sent him an email making sure that he is ok with us checking them in under the BSD license. I'm waiting to hear back from him. > On 2011-01-07 08:50:27, Steve Reinhardt wrote: > > src/cpu/BaseCPU.py, line 184 > > <http://reviews.m5sim.org/r/380/diff/1/?file=9025#file9025line184> > > > > Is this supposed to be here? It doesn't seem related to McPAT. What > > does it do anyway? Also, this should be done by adding a couple of new > > params with default '=None' values instead of duplicating code (note that > > this already seems broken wrt ARM and interrupt support when comparing with > > the preceding version). I'm going to defer this question to Joel. It seems to me that this is unused and not related to McPAT. However I want to hear from Joel before removing it. > On 2011-01-07 08:50:27, Steve Reinhardt wrote: > > src/cpu/o3/inst_queue_impl.hh, line 639 > > <http://reviews.m5sim.org/r/380/diff/1/?file=9034#file9034line639> > > > > I'm curious why this counts as a read and a write... is the write just > > the update to remove the inst? Shouldn't that be cheaper than actually > > writing a new instruction into the queue? Joel, do you have any thoughts on this? > On 2011-01-07 08:50:27, Steve Reinhardt wrote: > > src/cpu/base.hh, line 96 > > <http://reviews.m5sim.org/r/380/diff/1/?file=9026#file9026line96> > > > > This needs to be a System-object field, not a global, so it works when > > doing multi-system simulations. Done > On 2011-01-07 08:50:27, Steve Reinhardt wrote: > > src/cpu/base.hh, line 261 > > <http://reviews.m5sim.org/r/380/diff/1/?file=9026#file9026line261> > > > > Same here. Done - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/380/#review656 ----------------------------------------------------------- On 2011-01-10 10:48:23, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/380/ > ----------------------------------------------------------- > > (Updated 2011-01-10 10:48:23) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > mcpat: Adds McPAT performance counters > > Updated patches from Rick Strong's set that modify performance counters for > McPAT > > > Diffs > ----- > > src/cpu/BaseCPU.py 9f9e10967912 > src/cpu/base.cc 9f9e10967912 > src/cpu/o3/commit.hh 9f9e10967912 > src/cpu/o3/commit_impl.hh 9f9e10967912 > src/cpu/o3/cpu.hh 9f9e10967912 > src/cpu/o3/cpu.cc 9f9e10967912 > src/cpu/o3/iew_impl.hh 9f9e10967912 > src/cpu/o3/inst_queue.hh 9f9e10967912 > src/cpu/o3/inst_queue_impl.hh 9f9e10967912 > src/cpu/o3/rename.hh 9f9e10967912 > src/cpu/o3/rename_impl.hh 9f9e10967912 > src/cpu/o3/rob.hh 9f9e10967912 > src/cpu/o3/rob_impl.hh 9f9e10967912 > src/cpu/simple/atomic.cc 9f9e10967912 > src/cpu/simple/base.hh 9f9e10967912 > src/cpu/simple/base.cc 9f9e10967912 > src/cpu/simple/timing.cc 9f9e10967912 > src/sim/System.py 9f9e10967912 > src/sim/system.hh 9f9e10967912 > src/sim/system.cc 9f9e10967912 > > Diff: http://reviews.m5sim.org/r/380/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
