----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/522/#review917 -----------------------------------------------------------
Ship it! Looks fine. Two things though: 1) The documentation on the wiki needs to be updated along with this change. 2) I would like a separate email sent to the list saying that update_refs -> UPDATE_REFS. - Ali On 2011-02-28 04:54:41, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/522/ > ----------------------------------------------------------- > > (Updated 2011-02-28 04:54:41) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > SCons: Clean up some inconsistent capitalization in scons options. > > > Diffs > ----- > > SConstruct c6ba129c2764 > src/mem/protocol/SConsopts c6ba129c2764 > tests/SConscript c6ba129c2764 > > Diff: http://reviews.m5sim.org/r/522/diff > > > Testing > ------- > > > Thanks, > > Gabe > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
