----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/522/#review922 -----------------------------------------------------------
I'm willing to be convinced on this one, but I'd argue that the inconsistency is that VERBOSE should be lowercase, not that update_ref should be uppercase... I think I originally made update_ref lowercase to distinguish it from the sticky args that control the build itself, where the non-sticky vars are more like --foo command-line options (conceptually if not syntactically). Just some historical perspective from the guy who introduced update_ref. - Steve On 2011-02-28 04:54:41, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/522/ > ----------------------------------------------------------- > > (Updated 2011-02-28 04:54:41) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > SCons: Clean up some inconsistent capitalization in scons options. > > > Diffs > ----- > > SConstruct c6ba129c2764 > src/mem/protocol/SConsopts c6ba129c2764 > tests/SConscript c6ba129c2764 > > Diff: http://reviews.m5sim.org/r/522/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
