----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/570/#review946 -----------------------------------------------------------
src/arch/arm/isa/insts/branch.isa <http://reviews.m5sim.org/r/570/#comment1318> The ternary operator here seems redundant since rounding down the ARM pc would be a nop. Beyond that, there should be a space after the comma and before the 4. src/arch/arm/isa/insts/branch.isa <http://reviews.m5sim.org/r/570/#comment1319> Why the triple quotes? src/arch/arm/predecoder.hh <http://reviews.m5sim.org/r/570/#comment1322> This is the size fix I was talking about before, I'm pretty sure. This should make the RFE microcode change you posted before unnecessary. - Gabe On 2011-03-11 15:21:28, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/570/ > ----------------------------------------------------------- > > (Updated 2011-03-11 15:21:28) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ARM: Identify branches as conditional or unconditional and direct or > indirect. > > > Diffs > ----- > > src/arch/arm/insts/branch.hh 5138d1e453f1 > src/arch/arm/isa/insts/branch.isa 5138d1e453f1 > src/arch/arm/isa/templates/branch.isa 5138d1e453f1 > src/arch/arm/predecoder.hh 5138d1e453f1 > src/arch/arm/types.hh 5138d1e453f1 > src/cpu/o3/bpred_unit_impl.hh 5138d1e453f1 > > Diff: http://reviews.m5sim.org/r/570/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
