----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/570/#review953 -----------------------------------------------------------
src/cpu/o3/bpred_unit_impl.hh <http://reviews.m5sim.org/r/570/#comment1328> OK, I just looked at this again. The reason the code works is that before it gets to this part of the code, the BPUnit calls a generic squash that will take care of all branches after this (I guess that's why I left the comment above that line saying squash AFTER this ...) It's not lucky so to speak, because the only thing left at the top of the prediction history is the actual squashing instruction and it *should* be OK to not have to search through the prediction history list here (phew!). Regrettably, I left the DPRINTF there preceding the assert because it's real annoying if you break at that point in the code and the assert doesnt give you enough information to trace the problem. However, I guess that's mostly a development issue so it's probably the right thing to do is WACK all of that code and leave in a assert or panic at that spot ensuring that the seqNum is the prediction history at the front. Are you seeing cases where you have to search through the list there to get the branch prediction right? - Korey On 2011-03-11 15:21:28, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/570/ > ----------------------------------------------------------- > > (Updated 2011-03-11 15:21:28) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ARM: Identify branches as conditional or unconditional and direct or > indirect. > > > Diffs > ----- > > src/arch/arm/insts/branch.hh 5138d1e453f1 > src/arch/arm/isa/insts/branch.isa 5138d1e453f1 > src/arch/arm/isa/templates/branch.isa 5138d1e453f1 > src/arch/arm/predecoder.hh 5138d1e453f1 > src/arch/arm/types.hh 5138d1e453f1 > src/cpu/o3/bpred_unit_impl.hh 5138d1e453f1 > > Diff: http://reviews.m5sim.org/r/570/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
