> On 2011-04-23 20:44:57, Nathan Binkert wrote: > > The main question I have about this code is, should new Ruby code adhere to > > the style guide instead of the old Ruby style? Eventually, we should try > > migrate Ruby to the style guide, no? (I'm mostly talking about variable > > naming here)
I think we need to do that in a separate patch. Right now using Ruby style makes the code easier to read. That being said, the current Ruby code isn't consistent using the old style, and I completely agree that we should eventually convert over to a single style. - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/653/#review1149 ----------------------------------------------------------- On 2011-04-22 15:16:58, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/653/ > ----------------------------------------------------------- > > (Updated 2011-04-22 15:16:58) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > network: convert links & switches to first class C++ SimObjects > > This patch converts links and switches from second class simobjects that were > virtually ignored by the networks (both simple and Garnet) to first class > simobjects that directly correspond to c++ ojbects manipulated by the > topology and network classes. This is especially true for Garnet, where the > links and switches directly correspond to specific C++ objects. > > By making this change, many aspects of the Topology class were simplified. > > > Diffs > ----- > > configs/ruby/MESI_CMP_directory.py 914389024c33 > configs/ruby/MI_example.py 914389024c33 > configs/ruby/MOESI_CMP_directory.py 914389024c33 > configs/ruby/MOESI_CMP_token.py 914389024c33 > configs/ruby/MOESI_hammer.py 914389024c33 > configs/ruby/Network_test.py 914389024c33 > configs/ruby/Ruby.py 914389024c33 > src/mem/protocol/RubySlicc_Exports.sm 914389024c33 > src/mem/ruby/network/BasicLink.hh PRE-CREATION > src/mem/ruby/network/BasicLink.cc PRE-CREATION > src/mem/ruby/network/BasicLink.py PRE-CREATION > src/mem/ruby/network/BasicRouter.hh PRE-CREATION > src/mem/ruby/network/BasicRouter.cc PRE-CREATION > src/mem/ruby/network/BasicRouter.py PRE-CREATION > src/mem/ruby/network/Network.hh 914389024c33 > src/mem/ruby/network/Network.py 914389024c33 > src/mem/ruby/network/SConscript 914389024c33 > src/mem/ruby/network/Topology.hh PRE-CREATION > src/mem/ruby/network/Topology.cc PRE-CREATION > src/mem/ruby/network/garnet/fixed-pipeline/CreditLink_d.hh 914389024c33 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.hh PRE-CREATION > src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.cc PRE-CREATION > src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.py PRE-CREATION > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh 914389024c33 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 914389024c33 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetRouter_d.py PRE-CREATION > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.hh 914389024c33 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.cc 914389024c33 > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.hh 914389024c33 > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.cc 914389024c33 > src/mem/ruby/network/garnet/fixed-pipeline/SConscript 914389024c33 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetLink.hh PRE-CREATION > src/mem/ruby/network/garnet/flexible-pipeline/GarnetLink.cc PRE-CREATION > src/mem/ruby/network/garnet/flexible-pipeline/GarnetLink.py PRE-CREATION > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh 914389024c33 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 914389024c33 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetRouter.py PRE-CREATION > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.hh 914389024c33 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.cc 914389024c33 > src/mem/ruby/network/garnet/flexible-pipeline/Router.hh 914389024c33 > src/mem/ruby/network/garnet/flexible-pipeline/Router.cc 914389024c33 > src/mem/ruby/network/garnet/flexible-pipeline/SConscript 914389024c33 > src/mem/ruby/network/orion/NetworkPower.cc 914389024c33 > src/mem/ruby/network/simple/SimpleNetwork.hh 914389024c33 > src/mem/ruby/network/simple/SimpleNetwork.cc 914389024c33 > src/mem/ruby/network/topologies/Crossbar.py 914389024c33 > src/mem/ruby/network/topologies/Mesh.py 914389024c33 > src/mem/ruby/network/topologies/MeshDirCorners.py 914389024c33 > src/mem/ruby/slicc_interface/AbstractController.hh 914389024c33 > src/mem/ruby/slicc_interface/Controller.py 914389024c33 > > Diff: http://reviews.m5sim.org/r/653/diff > > > Testing > ------- > > > Thanks, > > Brad > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
