----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/653/#review1158 -----------------------------------------------------------
Ship it! Looks good to me Brad. I presume you already did extensive testing with Network_test and other protocols. Unless anyone has concerns, you can push it in. I'll wait for your patch that updates the bw parameters for both networks. - Tushar On 2011-04-25 15:43:08, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/653/ > ----------------------------------------------------------- > > (Updated 2011-04-25 15:43:08) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > network: convert links & switches to first class C++ SimObjects > > This patch converts links and switches from second class simobjects that were > virtually ignored by the networks (both simple and Garnet) to first class > simobjects that directly correspond to c++ ojbects manipulated by the > topology and network classes. This is especially true for Garnet, where the > links and switches directly correspond to specific C++ objects. > > By making this change, many aspects of the Topology class were simplified. > > > Diffs > ----- > > configs/ruby/MESI_CMP_directory.py b02bca5aed04 > configs/ruby/MI_example.py b02bca5aed04 > configs/ruby/MOESI_CMP_directory.py b02bca5aed04 > configs/ruby/MOESI_CMP_token.py b02bca5aed04 > configs/ruby/MOESI_hammer.py b02bca5aed04 > configs/ruby/Network_test.py b02bca5aed04 > configs/ruby/Ruby.py b02bca5aed04 > src/mem/protocol/RubySlicc_Exports.sm b02bca5aed04 > src/mem/ruby/network/BasicLink.hh PRE-CREATION > src/mem/ruby/network/BasicLink.cc PRE-CREATION > src/mem/ruby/network/BasicLink.py PRE-CREATION > src/mem/ruby/network/BasicRouter.hh PRE-CREATION > src/mem/ruby/network/BasicRouter.cc PRE-CREATION > src/mem/ruby/network/BasicRouter.py PRE-CREATION > src/mem/ruby/network/Network.hh b02bca5aed04 > src/mem/ruby/network/Network.py b02bca5aed04 > src/mem/ruby/network/SConscript b02bca5aed04 > src/mem/ruby/network/Topology.hh PRE-CREATION > src/mem/ruby/network/Topology.cc PRE-CREATION > src/mem/ruby/network/garnet/fixed-pipeline/CreditLink_d.hh b02bca5aed04 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.hh PRE-CREATION > src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.cc PRE-CREATION > src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.py PRE-CREATION > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh b02bca5aed04 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc b02bca5aed04 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetRouter_d.py PRE-CREATION > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.hh b02bca5aed04 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.cc b02bca5aed04 > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.hh b02bca5aed04 > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.cc b02bca5aed04 > src/mem/ruby/network/garnet/fixed-pipeline/SConscript b02bca5aed04 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetLink.hh PRE-CREATION > src/mem/ruby/network/garnet/flexible-pipeline/GarnetLink.cc PRE-CREATION > src/mem/ruby/network/garnet/flexible-pipeline/GarnetLink.py PRE-CREATION > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh b02bca5aed04 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc b02bca5aed04 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetRouter.py PRE-CREATION > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.hh b02bca5aed04 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.cc b02bca5aed04 > src/mem/ruby/network/garnet/flexible-pipeline/Router.hh b02bca5aed04 > src/mem/ruby/network/garnet/flexible-pipeline/Router.cc b02bca5aed04 > src/mem/ruby/network/garnet/flexible-pipeline/SConscript b02bca5aed04 > src/mem/ruby/network/orion/NetworkPower.cc b02bca5aed04 > src/mem/ruby/network/simple/SimpleNetwork.hh b02bca5aed04 > src/mem/ruby/network/simple/SimpleNetwork.cc b02bca5aed04 > src/mem/ruby/network/topologies/Crossbar.py b02bca5aed04 > src/mem/ruby/network/topologies/Mesh.py b02bca5aed04 > src/mem/ruby/network/topologies/MeshDirCorners.py b02bca5aed04 > src/mem/ruby/slicc_interface/AbstractController.hh b02bca5aed04 > src/mem/ruby/slicc_interface/Controller.py b02bca5aed04 > > Diff: http://reviews.m5sim.org/r/653/diff > > > Testing > ------- > > > Thanks, > > Brad > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
