----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/653/ -----------------------------------------------------------
(Updated 2011-04-25 15:30:56.730543) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary ------- network: convert links & switches to first class C++ SimObjects This patch converts links and switches from second class simobjects that were virtually ignored by the networks (both simple and Garnet) to first class simobjects that directly correspond to c++ ojbects manipulated by the topology and network classes. This is especially true for Garnet, where the links and switches directly correspond to specific C++ objects. By making this change, many aspects of the Topology class were simplified. Diffs (updated) ----- configs/ruby/MESI_CMP_directory.py 07f36463d602 configs/ruby/MI_example.py 07f36463d602 configs/ruby/MOESI_CMP_directory.py 07f36463d602 configs/ruby/MOESI_CMP_token.py 07f36463d602 configs/ruby/MOESI_hammer.py 07f36463d602 configs/ruby/Network_test.py 07f36463d602 configs/ruby/Ruby.py 07f36463d602 src/mem/protocol/RubySlicc_Exports.sm 07f36463d602 src/mem/ruby/network/BasicLink.hh PRE-CREATION src/mem/ruby/network/BasicLink.cc PRE-CREATION src/mem/ruby/network/BasicLink.py PRE-CREATION src/mem/ruby/network/BasicRouter.hh PRE-CREATION src/mem/ruby/network/BasicRouter.cc PRE-CREATION src/mem/ruby/network/BasicRouter.py PRE-CREATION src/mem/ruby/network/Network.hh 07f36463d602 src/mem/ruby/network/Network.py 07f36463d602 src/mem/ruby/network/SConscript 07f36463d602 src/mem/ruby/network/Topology.hh 07f36463d602 src/mem/ruby/network/Topology.cc 07f36463d602 src/mem/ruby/network/garnet/fixed-pipeline/CreditLink_d.hh 07f36463d602 src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.hh PRE-CREATION src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.cc PRE-CREATION src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.py PRE-CREATION src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh 07f36463d602 src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 07f36463d602 src/mem/ruby/network/garnet/fixed-pipeline/GarnetRouter_d.py PRE-CREATION src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.hh 07f36463d602 src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.cc 07f36463d602 src/mem/ruby/network/garnet/fixed-pipeline/Router_d.hh 07f36463d602 src/mem/ruby/network/garnet/fixed-pipeline/Router_d.cc 07f36463d602 src/mem/ruby/network/garnet/fixed-pipeline/SConscript 07f36463d602 src/mem/ruby/network/garnet/flexible-pipeline/GarnetLink.hh PRE-CREATION src/mem/ruby/network/garnet/flexible-pipeline/GarnetLink.cc PRE-CREATION src/mem/ruby/network/garnet/flexible-pipeline/GarnetLink.py PRE-CREATION src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh 07f36463d602 src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 07f36463d602 src/mem/ruby/network/garnet/flexible-pipeline/GarnetRouter.py PRE-CREATION src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.hh 07f36463d602 src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.cc 07f36463d602 src/mem/ruby/network/garnet/flexible-pipeline/Router.hh 07f36463d602 src/mem/ruby/network/garnet/flexible-pipeline/Router.cc 07f36463d602 src/mem/ruby/network/garnet/flexible-pipeline/SConscript 07f36463d602 src/mem/ruby/network/orion/NetworkPower.cc 07f36463d602 src/mem/ruby/network/simple/SimpleNetwork.hh 07f36463d602 src/mem/ruby/network/simple/SimpleNetwork.cc 07f36463d602 src/mem/ruby/network/topologies/Crossbar.py 07f36463d602 src/mem/ruby/network/topologies/Mesh.py 07f36463d602 src/mem/ruby/network/topologies/MeshDirCorners.py 07f36463d602 src/mem/ruby/slicc_interface/AbstractController.hh 07f36463d602 src/mem/ruby/slicc_interface/Controller.py 07f36463d602 Diff: http://reviews.m5sim.org/r/653/diff Testing ------- Thanks, Brad _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev