> On 2011-05-02 12:51:56, Nathan Binkert wrote: > > SConstruct, line 247 > > <http://reviews.m5sim.org/r/668/diff/1/?file=12211#file12211line247> > > > > Should we prompt the user for permission? That way the user would at > > least know that something happened. > > Steve Reinhardt wrote: > I doubt most people care. How many would really say no? Most people > just want things to be automatic. > > If they really do care they can always edit it out later (the comments > will let them know where the hooks came from). >
I agree that nobody would say no, but most people also would never notice that it had happened because the message would just fly by if there was no prompt. I guess that you're arguing that that would be a good thing :) > On 2011-05-02 12:51:56, Nathan Binkert wrote: > > SConstruct, line 243 > > <http://reviews.m5sim.org/r/668/diff/1/?file=12211#file12211line243> > > > > I know you didn't change this, but should we check for both hooks? (I > > added the pre-qrefresh one a while ago) > > Steve Reinhardt wrote: > Doesn't make me much difference... seems pretty unlikely anyone would > have one and not the other though. Old repos may not have the new hook. (I only found out that we could use pre-qrefresh a few months ago). - Nathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/668/#review1173 ----------------------------------------------------------- On 2011-05-02 12:34:56, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/668/ > ----------------------------------------------------------- > > (Updated 2011-05-02 12:34:56) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > SConstruct: automatically update .hg/hgrc with style hooks > > Seems easier than pestering people about it. > Note also that path is now absolute, so you don't get errors > when invoking hg from subdirectories. > > > Diffs > ----- > > SConstruct 66a3187a6714 > > Diff: http://reviews.m5sim.org/r/668/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
