> On 2011-05-02 12:51:56, Nathan Binkert wrote: > > SConstruct, line 243 > > <http://reviews.m5sim.org/r/668/diff/1/?file=12211#file12211line243> > > > > I know you didn't change this, but should we check for both hooks? (I > > added the pre-qrefresh one a while ago) > > Steve Reinhardt wrote: > Doesn't make me much difference... seems pretty unlikely anyone would > have one and not the other though. > > Nathan Binkert wrote: > Old repos may not have the new hook. (I only found out that we could use > pre-qrefresh a few months ago).
The only hitch is that if we just append the hook text when only one is missing we'll get duplicates, like this: [extensions] style = /home/stever/hg/amd/m5/util/style.py [hooks] pretxncommit.style = python:style.check_style # The following lines were automatically added by m5/SConstruct # to provide the m5 style-checking hooks [extensions] style = /home/stever/hg/amd/m5/util/style.py [hooks] pretxncommit.style = python:style.check_style pre-qrefresh.style = python:style.check_style # End of SConstruct additions I don't think it's a problem (my very limited testing hasn't shown anything), but it is a little weird. If you think this is OK, then I'll go ahead and test for both. Otherwise I could test for both, print a warning if they're only half there, and only do the auto append if they're both missing. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/668/#review1173 ----------------------------------------------------------- On 2011-05-02 12:34:56, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/668/ > ----------------------------------------------------------- > > (Updated 2011-05-02 12:34:56) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > SConstruct: automatically update .hg/hgrc with style hooks > > Seems easier than pestering people about it. > Note also that path is now absolute, so you don't get errors > when invoking hg from subdirectories. > > > Diffs > ----- > > SConstruct 66a3187a6714 > > Diff: http://reviews.m5sim.org/r/668/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
