I'd probably agree with Joel here. If we are going to have a distinction between trace and debug flags, then I'd rather see us literally have two settings..."--trace-flags" and "--debug-flags" as well as "trace-start" and "debug-start".
If/when the true debug flags come, this would make a clear distinction between what flags can do special debug tasks and what other tasks are just trace-flags. It is really confusing to have "debug-flags" that would be activated by a "trace-start". Trying to explain the difference between the two settings kind of underscores my point about it being confusing. So if it's not too late to suggest this change, I'd advocate having separate trace-flags and separate debug-flags. TraceFlags just for the execution tracing and DebugFlags for whatever new functionality. Maybe even have DebugFlags derive from TraceFlags so as that all debug flags would be a superset of the trace flags. If it is too late too change, I'd say either make everything "debug-flags", "debug-start" or just make things "trace-flags", "trace-start", but mixing the two things I dont think is a good idea. On Sat, May 7, 2011 at 7:10 PM, Gabe Black <gbl...@eecs.umich.edu> wrote: > I think the reason those wouldn't be renamed is that you're only > outputing something you could put in a file (in the traditional sense) > if you're tracing. If you're turning on/off some other functionality > like a debug breakpoint you're not tracing, you're debugging. It gets a > little confusing, I think, because we're so used to thinking about using > it for tracing and there aren't really true debug flags at the moment. > > Gabe > > On 05/07/11 15:15, Joel Hestness wrote: > > Hey guys, > > I wasn't sure what the intended outcome with tracing v. debugging was > > going to be. It sounds like the move is to "debug" as a more general > term, > > though it will support all of the "trace" functionality. In that case, > my > > confusion arose from the naming of the flags. Since "trace-file" and > > "trace-start" now go along with the other debug flags (i.e. you wouldn't > use > > them unless you're using the debug flags), it probably makes sense to > change > > the names to reflect the connection. For instance, "debug-trace-file" > and > > "debug-trace-start" are clearer and still reflect that you'll be > collecting > > a trace. > > Joel > > > > > >> I was thinking og doing it since Nate is not around. I'll do it soon. > >> > >> > >>>> instance, "trace-flags", and "trace-file" are still accepted, but they > >>>> don't > >>>> do anything now. They should be eliminated from the message. We're > >> also > >>>> missing the equivalent of "trace-start" and "trace-file". Do you mind > >>>> cleaning that up? > >> Are you sure that trace-file doesn't work? I've basically renamed > >> --trace-help to --debug-help, so the former can be removed. Also I've > >> renamed --trace-flags to --debug-flags, so that one can be removed > >> too. (I intended to, I just screwed up.) The purpose of renaming > >> trace flags to debug flags is that the flags themselves can be used > >> for a lot more than tracing (I'm starting to use them to insert > >> debugging breakpoints, they're used for exec trace which is really a > >> different tracing facility, they can be used for whatever) and it > >> seemed odd to have two different classes of flags (though we could do > >> that if we wanted to). > >> > >> The only error that I know of right now is that --trace-help and > >> --trace-flags still exist and silently act when they shouldn't. I'm > >> compiling right now, but things are slow on my laptop. I'll test out > >> --trace-file, but I'm not sure why that would have changed at all. > >> > >> Nate > >> _______________________________________________ > >> m5-dev mailing list > >> m5-dev@m5sim.org > >> http://m5sim.org/mailman/listinfo/m5-dev > >> > > > > > > _______________________________________________ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev > -- - Korey _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
