I looked over the diff .. couple of notes below.
Glad you trapped the test vector errors!
Simon Josefsson wrote:
Hello Elwyn, and thanks for your careful review!
I have incorporated most of your suggestions (see below) and updated
the document. The new document, with yours (and others) fixes, is
available from:
http://josefsson.org/base-encoding/draft-josefsson-rfc3548bis.txt
The differences compared to the version in last call can be found at:
http://josefsson.org/base-encoding/draft-josefsson-rfc3548bis-from--02.diff.html
I would appreciate if you could double-check that I merged all your
suggestions correctly, but I understand if you don't have time to do
this.
Elwyn Davies <[EMAIL PROTECTED]> writes:
I was selected as General Area Review Team reviewer for this specification
(for background on Gen-ART, please see
http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html).
Document: draft-josefsson-rfc3548bis-02
Intended Status: Proposed Standard (Individual submission via AD)
Shepherding AD: Ted Hardie
Review Trigger: IETF Last Call (ends 1 May 2006)
Summary:
This is almost ready for PS. I suspect (but don't know on account of
not being an IPR lawyer) that, in trying to do the 'right thing', the
author may have created an impossible (or maybe just excessively
complicated) copyright position regarding the code in s11. The
document now contains three different statements that are intended to
apply to the code: BCP78, the GNU copyright statements embedded in the
code and s15. Help!
I think you misread section 15. It doesn't apply to section 11.
True.. I know what you are trying to achieve but I have no idea if the
legalese works. :-(
The situation is intended to be like this (and from what I can tell,
is what the document says): LGPL applies to the code and only the
code. Section 15 (my own copying condition) cover what I wrote. The
IETF copying conditions cover the entire document, including the text
of the document that I copied from earlier RFCs
Aside from this there are a couple of minor issues (below) and a number of
Minor issues:
s11/s15: potential IPR (statement) issue: Is there any interaction
between the overall BCP78 copyright position, the GNU copyright
positions mentioned in the code sections and the author's statements
in s15? BCP78 seems to indicate that s11 could be freely copied and
wouldn't need any copyright statements.
The idea of an additional copyright statement is that when
redistributing the excerpted code, which is encouraged to happen, it
should have a copyright notice. The ISOC copyright notice does not
apply to my code, hence my own copyright notice.
I'll leave that one to the IP lawyers. I really have no idea.
s3.4, last para:
In this document, we document and *name* some currently used alphabets.
Names are not explicitly given to all the alphabets.
How so? The names are the names in section title, for each alphabet.
I was expecting a short, pithy name for each alphabet that would allow
them to be distinguished. I didn't feel that the whole of the section
title constituted a 'name', whereas some of them have (nearly) got
names: "base32", etc. I think an explicit name like this would help
future protocol designers to refer very precisely to the alphabet in use.
s11: Would be worth noting that it is assumed that the encoded input
has been stripped of embedded line feeds (if the specification needs
them) before applying the decoding functions.
Isn't this covered by the 'Note...' in the function description?
/* Decode base64 encoded input array IN of length INLEN to
output array OUT that can hold *OUTLEN bytes. Return
true if decoding was successful, i.e. if the input was
valid base64 data, false otherwise. If *OUTLEN is too
small, as many bytes as possible will be written to OUT.
On return, *OUTLEN holds the length of decoded bytes in
OUT. Note that as soon as any non-alphabet characters
are encountered, decoding is stopped and false is
returned. */
bool
base64_decode (const char *restrict in, size_t inlen,
char *restrict out, size_t *outlen)
Perhaps you could clarify what additional text you are looking for.
Sort of, but since you mention that some protocols need to split the
text into lines earlier, I thought it would be worth making it clear
that this code is intended to be applied after the line separators have
been removed.
The rest seems fine to me.
/Elwyn
_______________________________________________
Gen-art mailing list
[email protected]
https://www1.ietf.org/mailman/listinfo/gen-art