Hi.

Think we are almost done....

Simon Josefsson wrote:

<<snip>>

As regards the IPR stuff: We need a 'reading' from the IP lawyers. 'Nuff said.
s3.4, last para:
In this document, we document and *name* some currently used alphabets.
Names are not explicitly given to all the alphabets.
How so?  The names are the names in section title, for each alphabet.
I was expecting a short, pithy name for each alphabet that would allow
them to be distinguished.  I didn't feel that the whole of the section
title constituted a 'name', whereas some of them have (nearly) got
names: "base32", etc.  I think an explicit name like this would help
future protocol designers to refer very precisely to the alphabet in
use.

Oh, I see.  I agree.  I have added sentences like:

This encoding may be referred to as "base64".
This encoding may be referred to as "base64url".
This encoding may be referred to as "base32".
This encoding may be referred to as "base32hex"
...

See the updated URLs above.

Is this OK?
Fine by me.
s11: Would be worth noting that it is assumed that the encoded input
has been stripped of embedded line feeds (if the specification needs
them) before applying the decoding functions.
Isn't this covered by the 'Note...' in the function description?

   /* Decode base64 encoded input array IN of length INLEN to
      output array OUT that can hold *OUTLEN bytes.  Return
      true if decoding was successful, i.e. if the input was
      valid base64 data, false otherwise.  If *OUTLEN is too
      small, as many bytes as possible will be written to OUT.
      On return, *OUTLEN holds the length of decoded bytes in
      OUT.  Note that as soon as any non-alphabet characters
      are encountered, decoding is stopped and false is
      returned. */
   bool
   base64_decode (const char *restrict in, size_t inlen,
                  char *restrict out, size_t *outlen)

Perhaps you could clarify what additional text you are looking for.

Sort of, but since you mention that some protocols need to split the
text into lines earlier, I thought it would be worth making it clear
that this code is intended to be applied after the line separators
have been removed.

I've added the following to the comment:

   This means that, when applicable, you must de-fold any CRLF that is
   part of the data stream before calling this function.

Since it won't necessarily be CRLF, I would suggest s/CRLF/line terminators/

/Elwyn

_______________________________________________
Gen-art mailing list
[email protected]
https://www1.ietf.org/mailman/listinfo/gen-art

Reply via email to