Elwyn Davies <[EMAIL PROTECTED]> writes:

> Hi.
>
> Think we are almost done....

Yup.  Thanks for following up on the review.

>>>>    /* Decode base64 encoded input array IN of length INLEN to
>>>>       output array OUT that can hold *OUTLEN bytes.  Return
>>>>       true if decoding was successful, i.e. if the input was
>>>>       valid base64 data, false otherwise.  If *OUTLEN is too
>>>>       small, as many bytes as possible will be written to OUT.
>>>>       On return, *OUTLEN holds the length of decoded bytes in
>>>>       OUT.  Note that as soon as any non-alphabet characters
>>>>       are encountered, decoding is stopped and false is
>>>>       returned. */
>>>>    bool
>>>>    base64_decode (const char *restrict in, size_t inlen,
>>>>                   char *restrict out, size_t *outlen)
>>>>
>>>> Perhaps you could clarify what additional text you are looking for.
>>>>
>>>>         
>>> Sort of, but since you mention that some protocols need to split the
>>> text into lines earlier, I thought it would be worth making it clear
>>> that this code is intended to be applied after the line separators
>>> have been removed.
>>>     
>>
>> I've added the following to the comment:
>>
>>    This means that, when applicable, you must de-fold any CRLF that is
>>    part of the data stream before calling this function.
>>
>>   
> Since it won't necessarily be CRLF, I would suggest s/CRLF/line terminators/

Applied, and I also changed "de-fold" into "remove".

Thanks,
Simon

_______________________________________________
Gen-art mailing list
[email protected]
https://www1.ietf.org/mailman/listinfo/gen-art

Reply via email to