This was supposed to be done by May 1, but got buried in my Inbox. My
apologies.
I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
Please resolve these comments along with any other Last Call comments
you may receive.
Document: draft-ietf-manet-tlv-naming-02
Reviewer: Tom Taylor
Review Date: 10 May 2015
IETF LC End Date: 1 May 2015
IESG Telechat date: 14 May 2015
Summary: This document has minor issues that need to be resolved, along
with a few nits.
Major issues:
Minor issues:
1. If the requested TLV Type does not immediately define all the
corresponding type extensions for versions of that type, the Expert
Reviewer or IANA will be faced with the task of choosing an appropriate
Type value within which to place the extension. No guidance has been
provided for this purpose. What is the intention?
2. No IANA Considerations have been provided for the following registries:
TC Message-Type-specific Message TLV Types
TC Message-Type-specific Address Block TLV Types
HELLO Message-Type-specific Message TLV Types
HELLO Message-Type-specific Address Block TLV Types
SMF_TYPE Message TLV Type Extensions
SMF_NBR_TYPE Address Block TLV Type Extensions
Nits/editorial comments:
Sec. 1, third from last paragraph: s/consisteng/consistent/
Sec. 3.1, s/reguested/requested/ (both outer bullets, first line of each)
IANA Considerations, following Table 11: the current registry name is
"ICV[TIMESTAMP] Address TLV Type Extensions" (missing the word "Block").
This is inconsistent with the other address block TLV types. I suggest,
in place of the current text for these two extension registries, text to
resolve the inconsistency, as follows:
OLD
The IANA Registry "ICV[TIMESTAMP] Address Block TLV Type Extensions"
is unchanged.
NEW
The IANA Registry "ICV[TIMESTAMP] Address TLV Type Extensions" is
unchanged except to add the word "Block" after "Address" in the
registry name.
IANA Considerations, Table 13 and preceding text: the current registry
name is "NBR_ADDR_TYPE ....". This document refers to it as
"NBR_ADDR_TYPES ...." (i.e., plural). The inconsistency needs to be
resolved.
_______________________________________________
Gen-art mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/gen-art
