On 16/04/2009, Shanti Subramanyam <shanti.subraman...@sun.com> wrote:
> Thank you very much for your very prompt review.
>  Answers to your questions below.
>
>  Shanti
>
>  sebb wrote:
>
> > The OlioDriver.jar file contains a smaller OlioDriver.jar file.
> > This is very confusing; one of the jars should be renamed.
> >
> >
> >
>  This is the format of the Faban (http://faban.sunsource.net) Driver jar -
> the user never has to do anything with it as the tool will automatically
> unjar and put everything in it's right place.
>
> > The binary olio file contains several .patch and .diff files. These
> > don't seem correct for a binary file. What is their purpose?
> >
> >
> >
>  These files are part of the 3rd party plugin fixture_replacement2. Since we
> tend to include 3rd party code as is (for easier upgrade),  I think it might
> be better to leave them as they are.

But why are they in the binary rails jar, rather than in just the source jar?

> > The source PHP file contains several jars; I would expect these to be
> > in the binary archive only. It also contains the file "event.pdf"
> > which does not seem to belong in the archive (or indeed in SVN).
> >
> >
> >
>  These are third-party jars. They are included as a convenience to make it
> easier to build and run the source.

What about the event.pdf file?

>  Shanti
>
>
> >
> >
> > >  Thanks
> > >  Shanti
> > >
> > >
> > >
> > >  On 04/15/09 09:23, Shanti Subramanyam - PAE wrote:
> > >
> > >
> > >
> > > > The Olio community has voted and approved this first binary release of
> > > >
> > > >
> > > Olio. We are now asking for a Vote of the Incubator PMC to publish this
> > > release.
> > >
> > >
> > > > The release includes both the PHP and Rails versions of Olio.
> > > >
> > > > The release artificats and RAT reports are available here :
> > > > http://people.apache.org/~shanti/olio_0.1/
> > > >
> > > > The mail thread and Vote results from Olio community :
> > > >
> > > >
> > > >
> > >
> http://mail-archives.apache.org/mod_mbox/incubator-olio-dev/200904.mbox/ajax/%3c49dd6496.9010...@sun.com%3e
> > >
> > >
> > > > Thanks
> > > > Shanti
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> ---------------------------------------------------------------------
> > >
> > >
> > > > To unsubscribe, e-mail:
> > > >
> > > >
> > > general-unsubscr...@incubator.apache.org
> > >
> > >
> > > > For additional commands, e-mail:
> > > >
> > > >
> > > general-h...@incubator.apache.org
> > >
> > >
> > > >
> > > >
> > >
> ---------------------------------------------------------------------
> > >  To unsubscribe, e-mail:
> > > general-unsubscr...@incubator.apache.org
> > >  For additional commands, e-mail:
> > > general-h...@incubator.apache.org
> > >
> > >
> > >
> > >
> >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to