Agree. Regards JB
On Oct 29, 2016, 08:23, at 08:23, Dan Halperin <dhalp...@google.com.INVALID> wrote: >More on DEPENDENCIES: > >The latest version of Apache's maven-parent explicitly excludes it from >the >RAT check. [0] I see other projects have the same file e,g,. [1]. See >also >the linked issues from the Apache pom [2]. > >I think that file's presence may be WAI? > >[0] http://svn.apache.org/viewvc/maven/pom/tags/maven- >parent-27/pom.xml?revision=1704199&view=markup#l1029 >[1] https://dist.apache.org/repos/dist/release/isis/isis- >core/isis-1.13.0-source-release.zip >[2] https://issues.apache.org/jira/browse/RAT-184 > >On Fri, Oct 28, 2016 at 11:19 PM, Jean-Baptiste Onofré ><j...@nanthrax.net> >wrote: > >> Thanks Justin. >> >> Anyway I will double check the Kinesis client dependency definition. >> >> Thanks again >> Regards >> JB >> >> >> >> On Oct 29, 2016, 08:18, at 08:18, Justin Mclean ><jus...@classsoftware.com> >> wrote: >> >Hi, >> > >> >Changing my vote to +1 (binding). >> > >> >> Not sure I understand. If the dependency is optional and scope >> >provided, I don't think it's an issue. >> > >> >In the legal JIRA and the discussion on the dev list there's no >nothing >> >about if the dependancy is considered optional or not that I could >> >find. >> > >> >This of course may be obvious to people working on the project but >not >> >to people outside the project - so sorry about that. :-) >> > >> >> Kinesis IO will be used by a very small part of users imho (only >the >> >ones who needs pipelines connected with Kinesis). >> > >> >If that’s the case then IMO there no issue with the dependancy. >> > >> >Thanks, >> >Justin >> >>--------------------------------------------------------------------- >> >To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> >For additional commands, e-mail: general-h...@incubator.apache.org >>