On Mon, Apr 22, 2019 at 4:13 PM Minxuan Zhuang <z82507...@gmail.com> wrote:
> > ---------- Forwarded message --------- > From: Minxuan Zhuang <z82507...@gmail.com> > Date: Mon, Apr 22, 2019 at 4:08 PM > Subject: Re: Re: [VOTE]: Release Apache Dubbo Admin(Incubating) 0.2.0 [RC3] > To: <d...@dubbo.apache.org> > > > Hi, this LGPL License issue has been fixed, thanks kezhenxu94, I'll > cancel this vote and start a new one > > On Mon, Apr 22, 2019 at 3:09 PM Huxing Zhang <hux...@apache.org> wrote: > >> Hi, >> >> On Mon, Apr 22, 2019 at 1:38 PM kezhenxu94 <kezhenx...@163.com> wrote: >> > >> > Hi All, >> > I've excluded the `hibernate-core` dependency and verified as follows: >> > >> > >> > $ mvn license:add-third-party -Dlicense.useMissingFile >> > $ cat >> dubbo-admin-server/target/generated-sources/license/THIRD-PARTY.txt | grep >> "General Public License" >> > >> > >> > here is the output >> > >> > >> > (Eclipse Public License - v 1.0) (GNU Lesser General Public >> License) Logback Classic Module (ch.qos.logback:logback-classic:1.2.3 - >> http://logback.qos.ch/logback-classic) >> > (Eclipse Public License - v 1.0) (GNU Lesser General Public >> License) Logback Core Module (ch.qos.logback:logback-core:1.2.3 - >> http://logback.qos.ch/logback-core) >> > >> >> These are dual licensed dependencies, so we can choose the most >> permissive one. In this case EPL is compatible with Apache so no issue >> here. >> Be aware that General Public License is just on of the keyword, other >> keywords might also be check like GPL. >> >> > >> > also, I've tested that the functionality introduced together with this >> dependency[1] works well. >> > >> > >> > I'll check the license next time when I need to introduce new >> dependencies. >> > [1] https://github.com/apache/incubator-dubbo-admin/pull/324 >> > >> > >> > Thanks >> >>