Hi, +1 (binding)
I checked: - Incubating in name - DISCLAIMER exists - LICENSE is OK - NOTICE has some minor issues (see below) - All ASF file shave ASF headers - Not unexpected binary files - Can Compile from source The NOTICE file in general should not contain license information as that belongs in LICENSE. I see you copied all of the mybatis NOTICE file when it’s probably not needed. for instance does your release contain OGNL? I don’t think there any reason to mention Spring Framework in your NOTICE file as it has no NOTICE file. Thanks, Justin --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
