Thanks,I will remove the OGNL in the source notice next release.
I checkd over the soure notice file.
And I think the license information that you said and suggest to remove is that 
the following [1].

1.The license information need to removed out from the source notice
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.
  You may obtain a copy of the License at

  http://www.apache.org/licenses/LICENSE-2.0

  Unless required by applicable law or agreed to in writing, software
  distributed under the License is distributed on an "AS IS" BASIS,
  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  See the License for the specific language governing permissions and
  limitations under the License.

Thanks,
Gang Li


DolphinScheduler(Incubator) PPMC
Gang Li 李岗

lgcareer2...@outlook.com<mailto:lgcareer2...@outlook.com>
 
From: Justin Mclean
Date: 2020-07-13 17:36
To: general
Subject: Re: [VOTE] Release Apache DolphinScheduler (Incubating) 1.3.1 (ROUND2)
Hi,
 
> The first minor issue of the following I didn't understand clearly, whether 
> the notice file means both the binary notice file and source notice file.
 
I just looked at the source release.
 
> Yes,I copied all of the mybatis NOTICE file and put it into our binary notice 
> file and source notice file.I saw you suggest we to remove the useless parts 
> such as the OGNL.
 
You can keep it all but it a good idea to remove what’s not needed.
 
> The reason was that I searched the keyword on the github and found the notice 
> file of url 
> https://github.com/spring-projects/spring-framework/blob/v5.1.5.RELEASE/src/docs/dist/notice.txt.
 
There’s no NOTICE file at the top level so I would go with that, up to to you 
[1]
 
Thanks,
Justin
 
1. https://github.com/spring-projects/spring-framework/tree/v5.1.5.RELEASE
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
 

Reply via email to