Hi Kris,
Thanks for your review.
Indeed I missed the NOTICE file for binary release. The NOTICE.txt you have 
seen is just for source release.
For binary package, I have added new NOTICE for it, please help to review: 
https://github.com/apache/incubator-doris/pull/8813
And if that is OK, I will cancel this vote and start a new one to fix this 
issue.




--

此致!Best Regards
陈明雨 Mingyu Chen

Email:
chenmin...@apache.org





At 2022-04-01 22:57:14, "Calvin Kirs" <k...@apache.org> wrote:
>Hi,
>+ 0 (binding)
>I only checked source packages.
>
>- incubating in the name
>- LICENSE, NOTICE, DISCLAIMER are there and look good
>- hash and signature look good
>
>I have some questions about binary packages, which is why I chose +0.
>
>I checked the corresponding binary package, but the dependencies
>listed in his LICENSE file are inconsistent with those declared in the
>corresponding NOTICE file, because I'm not familiar with C++, I can't
>make an accurate judgment based on the source code or binary package.
>
>陈明雨 <morning...@163.com> 于2022年4月1日周五 13:37写道:
>>
>> Hi Li,
>> Thanks for your review. The Notice year has been modified in trunk[1], 
>> thanks for your mention!
>>
>>
>> [1] https://github.com/apache/incubator-doris/blob/master/NOTICE.txt
>>
>>
>>
>>
>> --
>>
>> 此致!Best Regards
>> 陈明雨 Mingyu Chen
>>
>> Email:
>> chenmin...@apache.org
>>
>>
>>
>>
>>
>> 在 2022-03-30 20:46:02,"li gang" <lgcar...@apache.org> 写道:
>> >+1 (not binding)
>> >I checked
>> >- LICENSE and NOTICE files exist
>> >- DISCLAIMER file exist
>> >- Include the word incubating in the release file name.
>> >- Signatures and hashes are fine
>> >
>> >Suggest update the Notice year of
>> >`apache-doris-1.0.0-incubating-src.tar.gz` to 2018-2022 in the next release.
>> >
>> >陈明雨 <morning...@163.com> 于2022年3月28日周一 10:00写道:
>> >
>> >> Hellp Incubator Community:
>> >>
>> >>
>> >> Please review and vote on Apache Doris 1.0.0-incubating-rc02 release.
>> >> Apache Doris is an MPP-based interactive SQL data warehousing for
>> >> reporting and analysis.
>> >>
>> >>
>> >> The Apache Doris community has voted on and approved this release. The
>> >> vote result is:
>> >> https://lists.apache.org/thread/j88ntr57rvylhh793cttqlth5xzjckp2
>> >>
>> >>
>> >> The release candidate has been tagged in GitHub as 1.0.0-rc02, available
>> >> here:
>> >> https://github.com/apache/incubator-doris/tree/1.0.0-rc02
>> >>
>> >>
>> >> The release not can be found here:
>> >> https://github.com/apache/incubator-doris/issues/8549
>> >>
>> >>
>> >> The artifacts (source, convenience binaries, signature and checksum)
>> >> corresponding to this release candidate can be found here:
>> >> https://dist.apache.org/repos/dist/dev/incubator/doris/1.0/1.0.0-rc02/
>> >> There is one source release package and 3 convenience binaries for Doris
>> >> Frontend, Backend and Broker module separately.
>> >>
>> >>
>> >> KEYS file is available here:
>> >> https://downloads.apache.org/incubator/doris/KEYS
>> >>
>> >>
>> >> The vote will be open for at least 72 hours.
>> >> [ ] +1 Approve the release
>> >> [ ] +0 No opinion
>> >> [ ] -1 Do not release this package because ...
>> >>
>> >>
>> >> ----
>> >> DISCLAIMER:
>> >> Apache Doris (incubating) is an effort undergoing incubation at The
>> >> Apache Software Foundation (ASF), sponsored by the Apache Incubator PMC.
>> >>
>> >>
>> >> Incubation is required of all newly accepted
>> >> projects until a further review indicates that the
>> >> infrastructure, communications, and decision making process have
>> >> stabilized in a manner consistent with other successful ASF
>> >> projects.
>> >>
>> >>
>> >> While incubation status is not necessarily a reflection
>> >> of the completeness or stability of the code, it does indicate
>> >> that the project has yet to be fully endorsed by the ASF.
>> >>
>> >>
>> >>
>> >>
>> >> --
>> >>
>> >> 此致!Best Regards
>> >> 陈明雨 Mingyu Chen
>> >>
>> >> Email:
>> >> chenmin...@apache.org
>> >
>> >
>> >
>> >--
>> >
>> >
>> >------------------------------
>> >Best Regards
>> >
>> >DolphinScheduler PMC
>> >Gang Li 李岗
>> >
>> >lgcar...@apache.org
>
>
>
>-- 
>Best wishes!
>CalvinKirs
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to