Hey Justin, Thank you for the validation. Just wanted to ask about the following:
> - There seems to be a minor LICENSE issue in that you have come 3rd party > licenses under "./licenses", but they are not mentioned in LICENSE. Is this > 3rd party code included in the source release? We have mentioned in NOTICE that under DEPENDENCIES file we keep track of all the deps. While some of them might use e.g. BSD-3 -Clause or similar (like passterm), we added these also to licenses directory. However, we only use them as libraries (not binaries) in our source code - in such a case, do we need anything else than the dependencies file (e.g. could we remove the licenses directory)? > - There are several 3rd party files that should be mentioned in LICENSE [2] By these 3rd party files do you have in mind the ones you listed from ./foreign/java directory? > - One unexpected binary file [1] Regarding these additional files in ./foreign/java - since we mostly use them to prepare our Java SDK library, should these even be a part of the release artifact? And whether these are part of the release or not, do we need to include either in LICENSE file or under ./licenses directory the info about gradle-wrapper.jar being used (it's the only jar file to be mentioned, correct)? As for the missing ASF headers in some files or invalid MIT license under cpp that's obvious to fix. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
