On Sat, Dec 28, 2013 at 05:57:05PM -0800, Brian Dolbec wrote: > Subject: Re: [gentoo-catalyst] [PATCH 1/6] modules/generic_stage_target.py: > USE portdir, distdir,... instead of paths for keys
I'd prefer “: Use” instead of “: USE”.
> -
> self.mounts=["/proc","/dev","/usr/portage","/usr/portage/distfiles","/var/tmp/portage"]
> -
> self.mountmap={"/proc":"/proc","/dev":"/dev","devpts":"/dev/pts",
> -
> "/usr/portage":self.settings["snapshot_cache_path"]+"/portage",\
> -
> "/usr/portage/distfiles":self.settings["distdir"],"/var/tmp/portage":"tmpfs"}
> + self.mounts=["proc", "dev", "portdir", "distdir",
> "port_tmpdir"]
> + self.mountmap={"proc":"/proc", "dev":"/dev",
> "devpts":"/dev/pts",
> +
> "portdir":self.settings["snapshot_cache_path"]+"/portage",\
> +
> "distdir":self.settings["distdir"],"port_tmpdir":"tmpfs"}
No need for the backslash after “"/portage",”. There should also
probably be a space before “"port_tmpdir"”. Style issues asside, the
content looks good to me.
Cheers,
Trevor
--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
signature.asc
Description: OpenPGP digital signature
