On Sat, Dec 28, 2013 at 05:57:10PM -0800, Brian Dolbec wrote:
> mounts and mountmap are source paths.

“mountmap” is for source paths.  “mounts” is for path-agnostic keys.

> -                     self.mounts.append("/var/cache/icecream")
> -                     
> self.mountmap["/var/cache/icecream"]="/var/cache/icecream"
> +                     self.mounts.append("icecream")
> +                     self.mountmap["icecream"] = self.settings["icecream"]

Looks good to me.

I haven't actually tested this series, but I did test two commits
further along in Brian's “pending” branch (8dfe5c7, Remove an extra
slash in the path, 2013-12-17).  Everything worked well there.  I'll
retest this series once we've worked the style kinks out of v1 ;).

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to