On Sun, Dec 29, 2013 at 05:50:51PM -0800, Brian Dolbec wrote:
> +PORT_LOGDIR_CLEAN = \
> + 'find "${PORT_LOGDIR}" -type f ! -name "summary.log*" -mtime +30
> -delete'
Pulling out this global variable is new for v2. I don't think I'm a
fan. I think it should either be hard-coded where we setup
env["PORT_LOGDIR_CLEAN"] (as it was before) or pulled out of
self.settings (like PORT_LOGDIR).
> - self.mounts.append("/var/log/portage")
> -
> self.mountmap["/var/log/portage"]=self.settings["port_logdir"]
> - self.env["PORT_LOGDIR"]="/var/log/portage"
> - self.env["PORT_LOGDIR_CLEAN"]='find "${PORT_LOGDIR}"
> -type f ! -name "summary.log*" -mtime +30 -delete'
> + self.mounts.append("port_logdir")
> + self.mountmap["port_logdir"] =
> self.settings["port_logdir"]
> + self.env["PORT_LOGDIR"] = self.settings["port_logdir"]
> + self.env["PORT_LOGDIR_CLEAN"] = PORT_LOGDIR_CLEAN
Other than the newly-global PORT_LOGDIR_CLEAN, this looks good to me.
Cheers,
Trevor
--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
signature.asc
Description: OpenPGP digital signature
