On Sun, Dec 29, 2013 at 05:50:52PM -0800, Brian Dolbec wrote: > Temporary location to define TARGET_MOUNTS, IT will be moved to a new > defaults.py file in a later commit.
“TARGET_MOUNTS, IT” → “TARGET_MOUNTS_DEFAULTS. It”.
I'd also wrap the long lines into paragraphs (just like email :), but
I'm fine if you'd rather stick with one line per sentence.
> +TARGET_MOUNTS_DEFAULTS = {
> + "ccache": "/var/tmp/ccache",
> + "dev": "/dev",
> + "devpts": "/dev/pts",
> + "distdir": "/usr/portage/distfiles",
> + "icecream": "/usr/lib/icecc/bin",
> + "kerncache": "/tmp/kerncache",
> + "packagedir": "/usr/portage/packages",
> + "portdir": "/usr/portage",
> + "port_tmpdir": "/var/tmp/portage",
> + "port_logdir": "/var/log/portage",
> + "proc": "/proc",
> + }
> +
+1 for alphebetizing this.
The rest of the patch matches v1#5 (less the v2#4 changes) with the
future-predicting comments pulled out. All of that looks good too.
Cheers,
Trevor
--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
signature.asc
Description: OpenPGP digital signature
