On Sun, Dec 29, 2013 at 09:32:35PM -0800, Brian Dolbec wrote: > On Sun, 2013-12-29 at 20:02 -0800, W. Trevor King wrote: > > That's a long subject ;). How about: > > > > Add "local_overlay" to configdefaults > > > > Fixes commit 463d98f (modules/generic_stage_target.py: Use a > > 'local_overlay' setting instead of hard-coding '/usr/local/portage', > > 2012-12-19). > > > > That gives you both a concise summary and a more detailed body without > > making wrapping in `git log --oneline`. > > First: I'm not feeling well, so please don't take this too personally.
No problem. I don't think there's a particular hurry to address everything either, so if you want to just let things cook for a week and then get back to them when you're feeling better, that's certainly fine with me. > I committed exactly what you had in the previous review > (copy/paste). I knew it was too long, but when I tried breaking it > up, git puked on it. so I thought what the hell and left it. I > wasn't going to "waste" more time on it. I've pushed: git://tremily.us/catalyst.git pending with the commit-message cleanups I've suggested on v2. If you want me to help figure out why Git didn't like your earlier attempt, just let me know. Cheers, Trevor -- This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
signature.asc
Description: OpenPGP digital signature
