On Sun, 23 Jan 2005 17:22:00 -0500
Chris Gianelloni <[EMAIL PROTECTED]> wrote:

> On Sun, 2005-01-23 at 23:04 +0100, Alexander Mieland wrote:
> > If someone wants to build a binary package of basc-1.5.8, the
> > ebuild searches for the bash-tarball in ${DISTFILES}, but
> > there will be no bash-tarball if basc is to be installed as
> > binary by another user.
> 
> This is simple enough.
> 
> if [ ! -e ${DISTFILES}/bash-3.0.tar.bz2 ]
> then
>       die  "I could not find the bash-3.0.tar.bz2 file.  Please
>       download this
> file from $blah and copy it to ${DISTFILES}."
> fi

What about:

 if [ ! -e ${DISTFILES}/bash-3.0.tar.bz2 ]
 then
        eerror \
"I could not find the bash-3.0.tar.bz2 file. Please do:"
        eerror \
"# ebuild /var/db/pkg/${CATEGORY}/${PF}/${PF}.ebuild fetch"
        die "Please fetch bash sources."
 fi

Also, i think the SRC_URI should use mirror://gnu/ instead of the
primary GNU ftp address.

Oh, and something else i've seen in the ebuild:

> pkg_config() {
>       mkdir -p ${ROOT}/tmp/${PF}
>       cd ${ROOT}/tmp/${PF}

I don't think that this is a good idea. Think of people who want
to keep their /tmp in a very small tmpfs for instance... The best
would be to unpack in ${T} (or is it ${TMPDIR}?), since we now
there is room to compile there. ${WORKDIR} would also have been
an option, but portage won't create it for the pkg_config step.

-- 
TGL.

--
[email protected] mailing list

Reply via email to