On Monday 24 January 2005 00:18, Chris Gianelloni wrote:
> On Mon, 2005-01-24 at 00:08 +0100, Thomas de Grenier de Latour wrote:
> > What about:
> >
> > if [ ! -e ${DISTFILES}/bash-3.0.tar.bz2 ]
> > then
> > eerror \
> > "I could not find the bash-3.0.tar.bz2 file. Please do:"
> > eerror \
> > "# ebuild /var/db/pkg/${CATEGORY}/${PF}/${PF}.ebuild fetch"
> > die "Please fetch bash sources."
> > fi
>
> Sounds good to me.
>
> > Also, i think the SRC_URI should use mirror://gnu/ instead of the
> > primary GNU ftp address.
>
> This too.
>
> > Oh, and something else i've seen in the ebuild:
> > > pkg_config() {
> > > mkdir -p ${ROOT}/tmp/${PF}
> > > cd ${ROOT}/tmp/${PF}
> >
> > I don't think that this is a good idea. Think of people who want
> > to keep their /tmp in a very small tmpfs for instance... The best
> > would be to unpack in ${T} (or is it ${TMPDIR}?), since we now
> > there is room to compile there. ${WORKDIR} would also have been
> > an option, but portage won't create it for the pkg_config step.
>
> I'll agree with you. ${T} would probably be better. It would also
> reduce the need for using ${ROOT}.Great! Thanks for this suggestions. I'll modify my ebuild to fit these. But what do you mean with: > One other thing, we should probably clean up our build directory for > bash once we're done. that? -- http://de.gentoo-wiki.com Alexander Mieland (aka dma147) http://www.gentoo-stats.org Registered Linux-User #249600 http://www.php-programs.de GnuGPG-ID: 27491179 http://www.affen-in-not.de www.php-programs.de/dma147.asc
pgpP92QIZJcOb.pgp
Description: PGP signature
