On Tue, 2006-02-28 at 17:38 +0000, Ciaran McCreesh wrote:
> Sheesh, you'll probably claim that this isn't broken next too:
>
> if [ "${IS_UPGRADE}" = "1" ] ; then
> einfo "Removing old version ${REMOVE_PKG}"
>
> emerge -C "${REMOVE_PKG}"
> fi
Ciaran,
(and this is valid for all emails to technical lists,)
please save us some time and many emails by stating what is wrong when
you show a QA violation.
Many among us don't think in assembler and don't know enough about the
code to decide if/why something is wrong. This in turn causes someone
(like me) to send an email asking what is wrong, causing another reply
by you etc. etc.
It's a bit like me stating:
"The bug is in line 14:
i+=2
"
If you don't know the code you won't understand why.
Now if I said "line 14 increments by two, but then you won't ever get
out of the loop since the exit condition won't be met" everyone could
understand it and evaluate my statement.
If you show a wrong code snippet please explain _why_ it is wrong in the
same email.
Thanks,
Patrick
--
Stand still, and let the rest of the universe move
signature.asc
Description: This is a digitally signed message part
