On 11/03/2012 09:29 PM, Ben de Groot wrote: > On 4 November 2012 08:28, Ian Stakenvicius <[email protected]> wrote: >>> 03.11.12 09:04, Ben de Groot написав(ла): >>>> I think we need to come up with a better policy regarding elog >>>> messages, which would improve the signal to noise ratio. >>>> >> As of EAPI=4 (i think? maybe 3?) ebuild authors can use a simple test >> to see if $REPLACING_VERSIONS is empty or not to indicate whether the >> package is being newly installed or if it's being upgraded. Maybe, if >> package maintainers are so inclined, we can start using this feature >> to reduce the spam. (if we were really motivated we could even only >> provide relevant messages based on the version being replaced!) > > I think that would be a good idea. I would like to see repoman > complain about elog messages without REPLACING_VERSIONS.
I think has_version calls are also a good indicator that the ebuild is doing the right thing. Parsing bash can be somewhat error-prone for repoman, some I'd suggest a simple rule like "Warn if elog is called and the ebuild does not contain any calls to the has_version function or references to the REPLACING_VERSIONS variable." -- Thanks, Zac
