On 10/17/2015 02:52 PM, Ulrich Mueller wrote: >>>>>> On Sat, 17 Oct 2015, hasufell wrote: > >>> 2. eapply_user really belongs in the PM, especially if it's run by >>> default. And it needs patch applying function. And if we have to >>> implement patch applying function anyway, we may as well make it >>> public to avoid unnecessary duplication. > >> Unreliable. The ebuild may define its own src_prepare function > > That eapply_user is called can be enforced by repoman, or by a QA > warning. >
And still doesn't give sufficient control to the user. Documenting proper hooks is more useful. >> or the PM might define eapply_user as a no-op, which is valid as >> per PMS. > > Sure, it is implementation defined. Otherwise PMS would have to > specify all the details, e.g. where does the package manager look > for user-supplied patches and how are patch directories organised. > So either do it, or just remove it from EAPI=6.
