Gabriel Roldán ha scritto: > On Friday 27 June 2008 10:36:50 am Andrea Aime wrote: >> Hi all, >> so some time ago Chris proposed to make some code reviews >> on GeoServer commits. I still like the idea a lot, and >> from my personal perspective, Crucible looks easy and nice, >> whilst the Google one seem kind of process heavy. >> >> For reference: >> http://www.nabble.com/code-review-tools-td17153080.html >> >> Does anyone else have a preference? Can we start using >> some of these tools? >> >> I'm also wondering how these tools might shape our way to >> commit. Like, it seems to me they kind of go against >> a style of granular commits with a specific msg each, >> and more to a single commit that encompasses all the work >> needed to fix a bug or create a new feature? > > I didn't do a deep review of crucible, though still wonder why it should go > against granular commits...
Well, the thing is, you might have to look at a set of commits in order to get a picture of what was done. For example, usually Justin splits a bigger commit into a raft of smaller ones, each one having a specific explanation of what was done on the file being committed. But you have to look at the lot to figure out the change as a whole, otherwise you might lack context, bigger picture. So this granular approach is good for whoever tries to get the svn log of that file, because the commit message is specific, but needs some context when a review is in order (which might be managed by mail as well, like someone commits, and then sends a mail telling to treat a group of commits as a "whole"). > My concerns are now how much overlap will we have regarding jira. Hope they > integrate somehow? I thought I saw something about the integration on the crucible site... let me see... here: http://www.atlassian.com/software/crucible/features/integrate.jsp Cheers Andrea ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
