+1 on starting to use a code review tool. I don't have much of a preference, will delegate to you guys on that one. However I do think that the ability to do granular commits is necessary. There is nothing worse than looking through svn logs for a file and finding a bunch of commit messages that are meaningless for that file.
Andrea Aime wrote: > Hi all, > so some time ago Chris proposed to make some code reviews > on GeoServer commits. I still like the idea a lot, and > from my personal perspective, Crucible looks easy and nice, > whilst the Google one seem kind of process heavy. > > For reference: > http://www.nabble.com/code-review-tools-td17153080.html > > Does anyone else have a preference? Can we start using > some of these tools? > > I'm also wondering how these tools might shape our way to > commit. Like, it seems to me they kind of go against > a style of granular commits with a specific msg each, > and more to a single commit that encompasses all the work > needed to fix a bug or create a new feature? > > I personally like granular commits when building new features > (whilst I prefer the second style for bug fixes), > wondering if there is any way to group them so that you > can still make up tight messages but submit a group of > commits as a single review subject. > > Cheers > Andrea > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://sourceforge.net/services/buy/index.php > _______________________________________________ > Geoserver-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > > !DSPAM:4007,4864a6b2244261431913854! > -- Justin Deoliveira The Open Planning Project [EMAIL PROTECTED] ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
