Justin Deoliveira ha scritto: > Ciao Francesco, > > I took a quick look and quite impressive. Congrats to yourself and > Andrea for developing a great new module. > > However, is there any reason to keep this an extension and not a core > module? I think it would make sense since the security subsystem itself > is core.
The are two reason I can think of: - the UI is not consistent with the rest of GeoServer. For example, we still have a per line deletion link and the action links are below the table. - last time I checked editing the service level security will result in GeoServer failing to restart because we still rely on a Spring class mandating that roles do start with ROLE_ and the UI does not actually impose that anywhere The first issue is annoying but not a blocker imho, the second one is more serious and to solve it we'd have to replace that Spring class with a home grown one that does not impose silly restrictions: http://jira.codehaus.org/browse/GEOS-3446 Alternatively we'd have to review the UI so that all the restrictions are respected and remove the * usage from the service security setup Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
