Thanks Ben. Actually just running the tests last minute I found a test
failure in app-schema that I think requires some more discussion. It has to
do with how DescribeFeatureType deals with schemas that contain types from
different namespaces. In the past the behaviour was to create a schema with
no target namespace that contain only imports... pointing to the types from
the various namespaces.

However with WFS 2.0 one of the compliance tests requires that we actually
create a schema with a target namespace for the first type referenced... and
create imports only for the types in the other namespaces. Which leads to a
failure in the following app-schema tests:

  testDescribeFeatureType(org.geoserver.test.FeatureChainingWfsTest)

So I wanted to get your feedback first before going and changing any test
assertions. How do you think we should proceed? Should we change the test
assertion to allow for the new wfs 2.0 style... or should we change the code
to only adopt the new behaviour when we are responding to a wfs 2.0
DescribeFeatureType? I am thinking the latter is probably safest just in
terms of backward compatibility... but wanted to hear your take.

-Justin

On Mon, Oct 24, 2011 at 10:05 AM, Ben Caradoc-Davies
<[email protected]> wrote:

> +1.
>
> Outstanding work, Justin. This is so huge that the only way to understand
> it is to commit it to trunk and see how it works in the wild. It will take
> some time to digest all the implications. I am sure users will find some
> gotchas, but this is certainly a step in the right direction.
>
>
> On 23/10/11 01:18, Justin Deoliveira wrote:
>
>> Hi all,
>>
>> The WFS 2.0 proposal has been sitting for over a week now. I would like to
>> push this forward by calling for a vote if there is no more feedback. Or
>> gather more feedback / patch review in order to drive it closer to a vote.
>> Thanks, I realize it is a very large amount to review but at the same time I
>> fear if we leave it sitting for too long the work will grow stale and
>> further from being committed.
>>
>>   
>> http://geoserver.org/display/**GEOS/GSIP+61+-+WFS+2.0<http://geoserver.org/display/GEOS/GSIP+61+-+WFS+2.0>
>>
>> -Justin
>>
>> --
>> Justin Deoliveira
>> OpenGeo - http://opengeo.org
>> Enterprise support for open source geospatial.
>>
>>
>>
> --
> Ben Caradoc-Davies <[email protected]>
> Software Engineer
> CSIRO Earth Science and Resource Engineering
> Australian Resources Research Centre
>



-- 
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn 
about Cisco certifications, training, and career opportunities. 
http://p.sf.net/sfu/cisco-dev2dev
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to