Hello Andrea, All the changes that were made to those base classes were done to make those classes generic for different record types / schemes; either because the old version of those classes just assumed DC records and thus needed to be changed to support other types; or to avoid copy-pasting a lot of code for each record type / scheme.
On a first glance, I can't see why those two maps in the two classes below use a String as key (localpart) rather than the whole Name. I'm surprised myself that I did that. The only reason I can imagine right now is that sometimes people might make requests without specifying the namespace, and I wanted to allow that lazy behaviour. Apart from that I see no reason why we can't change the use of String by the use of Name in those maps. Kind Regards Niels On 25/02/14 15:02, Andrea Aime wrote: > Hi, > today I was trying to port over an ebRIM record implementation we made > some time > ago and, besides the several difficulties caused by the many changes to > the base classes I've found that the core CSW classes regressed and cannot > tell apart anymore two record types with the same name, but different > namespace > (we have a custom ebRim record that uses a different namespace and > uses extensions, in parallel > with the standard one): > http://jira.codehaus.org/browse/GEOS-6368 > > This is due to the extensive usage of getLocalName() in the current > implementation, > for example: > https://github.com/geoserver/geoserver/blob/2.4.x/src/extension/csw/api/src/main/java/org/geoserver/csw/store/AbstractCatalogStore.java#L49 > https://github.com/geoserver/geoserver/blob/2.4.x/src/extension/csw/api/src/main/java/org/geoserver/csw/store/CatalogStoreCapabilities.java > > Niels, I'm surprised that a developer with an app-schema background > would go there, > so I guess there are good reasons for this change, and I'm just not > seeing them? > > Regardless, this is a regression and needs to be fixed, but I would > like to understand what > challenges got us here to avoid exchanging one regression with another > > Cheers > Andrea > > -- > == Our support, Your Success! Visit http://opensdi.geo-solutions.it > for more information == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions S.A.S. > Via Poggio alle Viti 1187 > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 > fax: +39 0584 1660272 > mob: +39 339 8844549 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > ------------------------------------------------------- ------------------------------------------------------------------------------ Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis & security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk _______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
