On Tue, Feb 25, 2014 at 3:33 PM, Niels Charlier <ni...@scitus.be> wrote:
> Hello Andrea,
>
> All the changes that were made to those base classes were done to make
> those classes generic for different record types / schemes; either because
> the old version of those classes just assumed DC records and thus needed to
> be changed to support other types; or to avoid copy-pasting a lot of code
> for each record type / scheme.
>
Hem... I've implemented functioning support for ebRIM records based on
those classes (that is, extending them, no code duplication), so they were
definitely not hard-coded to csw:Record (nor assuming it), although I
understand that ISO support presents different challenges than ebRIM and
thus likely required modifications.
>
> On a first glance, I can't see why those two maps in the two classes below
> use a String as key (localpart) rather than the whole Name. I'm surprised
> myself that I did that. The only reason I can imagine right now is that
> sometimes people might make requests without specifying the namespace, and
> I wanted to allow that lazy behaviour. Apart from that I see no reason why
> we can't change the use of String by the use of Name in those maps.
>
Cool, I guess I'll make the fix and try to add tests so that we don't
regress on this aspect in the future
Cheers
Andrea
--
== Our support, Your Success! Visit http://opensdi.geo-solutions.it for
more information ==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
