Hi Kevin and Gabriel, I have a few questions regarding the jdbc resource store and the resource store API in general that I'd like to hear your opinion on. Including the mailing list because others might have thoughts on this.
1) The ResourceStore does not appear to provide anything for creating directories. At the moment GeoServerResourceLoader.getOrCreateDirectory is used for that. How can we change all modules to use the generic Resource Store rather than the file based one directly without such a method in the API? 2) In your implementation, the JDBCResource is using the OID primary key as a handle. At first I thought that made sense but I think there are some issues which respect to how the API assumes resources to work. Imagine that somebody else (possibly a different geoserver instance, as this is meant for clustering) overwrites the file or deletes it and then recreates one at the same location. Your resource holding the OID handle will be out of date. It might be able to notice the delete, but not the new content. But if you for example look at the rename test theory, it expects that both resources have changed to reflect the new reality. Many other parts of the API and the tests suggest that the ResourceStore is meant to support concurrent access. The way that File System resources work is that they are simply wrapping around a File which is basically just wrapping around String which holds the path, without any state stored. Each method will query the file system using that path. My idea is that the only way for the JDBCStore to have the same expected behaviour is to also use the full path as the handle and in each method query the database using the full path. Does that make sense? Do you agree with my conclusion? Kind Regards Niels ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
