On Wed, Dec 30, 2015 at 9:24 PM, Jody Garnett <jody.garn...@gmail.com> wrote:
> > >> We should also acknowledge the pain in the other direction - there is a >>> category of "small fixes" where our response (although understandable give >>> our limited resources) is viewed as out of line with respect to other open >>> source projects. >>> >> >> Can you provide some examples? I don't work very well with general >> statements. >> > > Should of been more clear that I agree with everything you say, and was > trying to add the idea of how we look to potential contributors into the > mix. Each case I can think of (jdbc timezone fix that I rejected, wps pull > request that went from simple to insurmountable) has a danger of > distracting from the point - that developers expect to be able to > contribute a fix and walk away. Both of those examples had very clear > reasons why they were rejected - but the impression remains that our > codebase is hard to work with. > Actually I believe in both cases the original developer in question just walked away a yard before the victory llne. In the case of the date one, at the end of the thread we offered a simple solution to the problem (handle the timezone shift for dates as part of a setting), in the second one I provided some feedback on how to address it that surely made it go from simple (but wrong, was reporting the process as started while it was actually still queued) to non trivial, but still a far cry from insurmountable, took me less than a hour to cook up a pull request while helping my daughter do her Christmas break homeworks. Full pull request: https://github.com/geoserver/geoserver/pull/1386 The actual fix: https://github.com/geoserver/geoserver/commit/275bd9886e538e384cd2796facef5cc499ba6582 I've preserved Dave's test in a separate commit, and doh, just looked at it forgot to add copyright headers, remove the tabs and so on, some more cleanup needed on this part... > > A review guide as you describe it, can help both those new to the > geoserver community conduct a review and feel confident in the result, and > those contributing to the project to know what to expect and that we are > treating them fairly/consistently. > All right, I'll try to cook up one. Cheers Andrea -- == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == *Geosolutions' Winter Holidays from 24/12 to 6/1* Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -------------------------------------------------------
------------------------------------------------------------------------------
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
