I feel like adding a review guide is an excellent idea. A single file with 2 headings may be better than seperate CONTRIBUTING.md and REVIEWING.md files, especially given the amount of duplicated information between the two proceedures.
Notably, the "Fast formal checks" section of the draft review guide closely mirrors the "Pull Request Guidelines / Commit guidelines" in CONTRIBUTING.md (and in many ways is better - having some justification for certain requirements that may seem arbitrary on the surface is a definite plus. Given the similarity of these two sections, perhaps they could be a combined section for both contributing and reviewing? Slightly off topic, but concerning the note about community modules - is there any checks we can enforce when a community module gets promoted to a regular module? I get the feeling that this has caused some issues with lower quality code making its way into geoserver without a proper review (Am I right in thinking that whenever a community module does get promoted to core, it is usually sufficiently large that it is hard to enforce such guidlines whithout substantial work from both the reviewer(s) and the contributor(s)). Torben On Mon, Jan 4, 2016 at 11:07 AM, Jody Garnett <jody.garn...@gmail.com> wrote: > > I use FindBugz when reviewing. >>> >> >> Interesting... is there a way to make it find bugs only in the modified >> sections of code, or at least modified files? >> > > I right click on the file and say "find bugz" :) You can also filter in > eclipse to only show modified files. > > You can use eclipse git staging view to show only things that have been > modified (ie by your pulling in the external pull request) > > >> Any way to automate it? Findbugs in desktop mode (IDE integration) >> requires actually fetching the pull request, something that I do for large >> ones, for simple ones it seems overkill. >> > > I was not automating, just treating it as the first step of my manual > review. > > Also... having findbugs run in IDE all time sounds like it would slow down >> the IDE a lot, how do you deal with that? >> > > I do not have the "builder" turned on all the time, only use to run > manually. > >> >> Cheers >> Andrea >> >> >> -- >> == >> GeoServer Professional Services from the experts! Visit >> http://goo.gl/it488V for more information. >> == >> >> *Geosolutions' Winter Holidays from 24/12 to 6/1* >> >> Ing. Andrea Aime >> @geowolf >> Technical Lead >> >> GeoSolutions S.A.S. >> Via Poggio alle Viti 1187 >> 55054 Massarosa (LU) >> Italy >> phone: +39 0584 962313 >> fax: +39 0584 1660272 >> mob: +39 339 8844549 >> >> http://www.geo-solutions.it >> http://twitter.com/geosolutions_it >> >> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* >> >> Le informazioni contenute in questo messaggio di posta elettronica e/o >> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il >> loro utilizzo è consentito esclusivamente al destinatario del messaggio, >> per le finalità indicate nel messaggio stesso. Qualora riceviate questo >> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di >> darcene notizia via e-mail e di procedere alla distruzione del messaggio >> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, >> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od >> utilizzarlo per finalità diverse, costituisce comportamento contrario ai >> principi dettati dal D.Lgs. 196/2003. >> >> >> >> The information in this message and/or attachments, is intended solely >> for the attention and use of the named addressee(s) and may be confidential >> or proprietary in nature or covered by the provisions of privacy act >> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection >> Code).Any use not in accord with its purpose, any disclosure, reproduction, >> copying, distribution, or either dissemination, either whole or partial, is >> strictly forbidden except previous formal approval of the named >> addressee(s). If you are not the intended recipient, please contact >> immediately the sender by telephone, fax or e-mail and delete the >> information in this message that has been received in error. The sender >> does not give any warranty or accept liability as the content, accuracy or >> completeness of sent messages and accepts no responsibility for changes >> made after they were sent or for other risks which arise as a result of >> e-mail transmission, viruses, etc. >> >> ------------------------------------------------------- >> > > > > ------------------------------------------------------------------------------ > > _______________________________________________ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > >
------------------------------------------------------------------------------
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
