On Mon, Jan 4, 2016 at 9:36 PM, Torben Barsballe < tbarsba...@boundlessgeo.com> wrote:
> I feel like adding a review guide is an excellent idea. > > A single file with 2 headings may be better than seperate CONTRIBUTING.md > and REVIEWING.md files, especially given the amount of duplicated > information between the two proceedures. > I guess we could have everything in the CONTRIBUTING.md one (which has a special treatment in github: https://github.com/blog/1184-contributing-guidelines) but others keep on asking to have it in the developer guide. If we want to avoid duplication, then CONTRIBUTING.md should link to the dev guide... I'm not a fan of indirections honestly, but let's hear what people want to do. > > Notably, the "Fast formal checks" section of the draft review guide > closely mirrors the "Pull Request Guidelines / Commit guidelines" in > CONTRIBUTING.md (and in many ways is better - having some justification for > certain requirements that may seem arbitrary on the surface is a definite > plus. Given the similarity of these two sections, perhaps they could be a > combined section for both contributing and reviewing? > Why not. > > Slightly off topic, but concerning the note about community modules - is > there any checks we can enforce when a community module gets promoted to a > regular module? I get the feeling that this has caused some issues with > lower quality code making its way into geoserver without a proper review > (Am I right in thinking that whenever a community module does get promoted > to core, it is usually sufficiently large that it is hard to enforce such > guidlines whithout substantial work from both the reviewer(s) and the > contributor(s)). > That's a good point, maybe we should add this as graduation criteria, having someone do a review according to the reviewing guide? Or even better, ask the module owners to first do a self-review based on the list of topics in the review guide, and when they think they are ready, have someone else check and confirm? Cheers Andrea -- == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == *Geosolutions' Winter Holidays from 24/12 to 6/1* Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003. The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. -------------------------------------------------------
------------------------------------------------------------------------------
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
