Can you tell me more above it the direct access to the coordinate array?
I did fix up the remaining coordinate sequence implementations last night,
but if you have any API requests now is the time.
If LiteCoordinateSequence is useful perhaps it is an approach to be taken
for JTS.
One idea that came up during implementation was
CoordinateSequence.createCoordinate( double ... ordinates ) to prevent
client code having to sort out what is required and allow sequences to
define new implementations.
On Wed, Aug 1, 2018 at 12:27 AM Andrea Aime <[email protected]>
wrote:
> On Wed, Aug 1, 2018 at 9:13 AM Jody Garnett <[email protected]>
> wrote:
>
>> Okay my PR is now tested and ready to go, with PackedCoordinateSequence
>> providing an implementation of the API.
>>
>
> Mind, GeoTools and GeoServer use extensively LiteCoordinateSequence to
> have maximum performance in WMS (but found
> it's used also in WFS) , as it gives direct access to its internal array
> (bad for JTS API wise, but fundamental to avoid reallocations in the
> rendering chain [1]).
> And oh, that's a PackedCoordinateSequence subclass!
>
> Hum... well I guess that LiteCoordinateSequence will just inherit the new
> functionality from its base class
> (as long as it's in PackedCoordinateSequence and not in its non abstract
> subclasses) :-)
>
> Jody, any reason not to have that method in all coordinate sequences, with
> a default implementation?
> Or at least have it in the most common one, CoordinateArraySequence?
>
> Cheers
> Andrea
>
> [1]: One thing Laurent Bourges suggested is to replace that coordinate
> sequence with a different one that
> would pool the ordinate arrays. That's how Marlin got its main performance
> boost, by avoiding allocating
> and throwing away lots of arrays. I did not find the time to look into it
> yet, and I'm not sure it will provide
> a measurable benefit, most of the time now seems to be spent in IO and
> encoding results.
>
> ==
>
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf
> Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa
> <https://maps.google.com/?q=Via+di+Montramito+3/A%0D%0A55054++Massarosa&entry=gmail&source=g>
> (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
> http://www.geo-solutions.it http://twitter.com/geosolutions_it
> ------------------------------------------------------- *Con riferimento
> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
> circostanza inerente alla presente email (il suo contenuto, gli eventuali
> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
> sarei comunque grato se potesse darmene notizia. This email is intended
> only for the person or entity to which it is addressed and may contain
> information that is privileged, confidential or otherwise protected from
> disclosure. We remind that - as provided by European Regulation 2016/679
> “GDPR” - copying, dissemination or use of this e-mail or the information
> herein by anyone other than the intended recipient is prohibited. If you
> have received this email by mistake, please notify us immediately by
> telephone or e-mail.*
>
--
--
Jody Garnett
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
