Based on your feedback, I've got no further concerns, so +1 from me. Per-item comments inline below:
>> - What does the "reset" button do? I assume it resets to native >> values? >> >> > Yep, bring the editable table back to match the native values. Would you > like to suggest a better name? > I think the name is fine, given I guessed right. Restore or Revert may be alternatives, but I think it is mostly a matter of taste, as long as the functionality is documented > >> 1. Also, do you expect to support some form of autocompletion of >> "source" based on the native schema of the data? I feel like this would be >> a useful feature, given that GeoServer is sometimes the only window users >> have into a given data set. >> >> This is a good idea, and could be part of the stretch goals. > I believe it would require using CodeMirror for the expression editor, and > writing a CQL grammar in javascript... which is definitely too much effort. > Can you think of a simpler way to get auto-complete in a text area? > > I was thinking something a little less sophisticated (basically disregarding more complicated expressions entirely, and only autocompleting individual names) - so just a text overlay listing the attribute names in the data source, filtered by whatever characters have already been typed. Definitely a stretch goal though. Cheers, Torben
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
