Hi all, Andrea, looks good to me, just a couple of comments: - Is the identifier (ID attribute) of the feature type fixed? I'm assuming it is. - If we define a new attribute that uses a complex CQL expression (for example a concatenation) I'm assuming that someone can send a filter that targets the value of that attribute, and GeoServer will take care of translating it properly behind the scenes: delegate it to the underlying data source if supported or execute it in memory as a last resort.
If my assumptions above are correct, you have my +1. Kind regards, Nuno Oliveira On Tue, Jan 4, 2022 at 5:08 PM Torben Barsballe <torbenbarsba...@gmail.com> wrote: > Based on your feedback, I've got no further concerns, so +1 from me. > Per-item comments inline below: > > >>> - What does the "reset" button do? I assume it resets to native >>> values? >>> >>> >> Yep, bring the editable table back to match the native values. Would you >> like to suggest a better name? >> > > I think the name is fine, given I guessed right. Restore or Revert may be > alternatives, but I think it is mostly a matter of taste, as long as the > functionality is documented > > >> >>> 1. Also, do you expect to support some form of autocompletion of >>> "source" based on the native schema of the data? I feel like this would >>> be >>> a useful feature, given that GeoServer is sometimes the only window users >>> have into a given data set. >>> >>> This is a good idea, and could be part of the stretch goals. >> I believe it would require using CodeMirror for the expression editor, >> and writing a CQL grammar in javascript... which is definitely too much >> effort. >> Can you think of a simpler way to get auto-complete in a text area? >> >> > I was thinking something a little less sophisticated (basically > disregarding more complicated expressions entirely, and only autocompleting > individual names) - so just a text overlay listing the attribute names in > the data source, filtered by whatever characters have already been typed. > Definitely a stretch goal though. > > > Cheers, > Torben > > _______________________________________________ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > -- Regards, Nuno Oliveira == GeoServer Professional Services from the experts! Visit http://bit.ly/gs-services-us for more information. == Nuno Miguel Carvalho Oliveira @nmcoliveira Technical Lead / Project Manager GeoSolutions Group phone: +39 0584 962313 fax: +39 0584 1660272 https://www.geosolutionsgroup.com/ http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
